Skip to content

Fixes #5544 #issuecomment-4836836706. FileDialog/OpenDialog: one unre…#5569

Merged
BDisp merged 2 commits into
tui-cs:developfrom
BDisp:issue/filedialog-unreadable-entry
Jul 1, 2026
Merged

Fixes #5544 #issuecomment-4836836706. FileDialog/OpenDialog: one unre…#5569
BDisp merged 2 commits into
tui-cs:developfrom
BDisp:issue/filedialog-unreadable-entry

Conversation

@BDisp

@BDisp BDisp commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Proposed Changes/Todos

  • Add fix and regression unit tests.

Summary:

  • Both tests fail as expected. The failure collection contains only the .. parent row, proving the current fix preserves parent navigation but still loses the readable entries when the listing call itself throws.
  • Changed FileDialogState to stop using the eager Get* methods altogether for normal listing. It will enumerate with EnumerationOptions.IgnoreInaccessible = true, then still wrap each returned entry defensively as before.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

…e unreadable entry makes the entire directory render empty (`FileDialogState.GetChildren` swallows the exception)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileDialog/OpenDialog: one unreadable entry makes the entire directory render empty (FileDialogState.GetChildren swallows the exception)

2 participants